Vote Details for "Services_TwitPic" by gauthierm

» Details
  • Voter: Michael Gauthier 
  • Vote: +1 (not conditional)
  • Reviews: Deep source review
» Comment
Nice clean and simple code.

1.) there's a typo 'endpoing' in Services_TwitPic_Request_Common
2.) documentation should not restate the method/class name
3.) method documentation should use 3rd person declarative rather than 2nd person imperative ('Sets foo' rather than 'Set foo'). See
4.) more specific exception types would be useful
5.) I think you can turn off errors in simplexml using libxml_use_internal_errors(). You can then manually handle the errors using libxml_get_errors(). You're right the SimpleXML documentation is lacking this information.
6.) available options are not documented. I recommend adding this to either the class documentation or the setOptions() documentation.
7.) a setOption() method that sets a single option might be handy. It could be used inside setOptions()