Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 3.6.2

Bug #16794 ValidLogicalOperatorsSniff doesn't report operators not in lowercase
Submitted: 2009-11-17 19:11 UTC
From: thezero Assigned: squiz
Status: Closed Package: PHP_CodeSniffer (version CVS)
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 26 + 15 = ?

 
 [2009-11-17 19:11 UTC] thezero (Jakub Tom├ínek)
Description: ------------ Squiz_Sniffs_Operators_ValidLogicalOperatorsSniff does not recognize "AND", "OR" or eg. "Xor" operators as CS errors. These operators are case-insensitive. Test script: --------------- <?php var_dump(true OR false); Expected result: ---------------- FOUND 1 ERROR(S) AND 0 WARNING(S) AFFECTING 1 LINE(S) 2 | ERROR | Logical operator "OR" is prohibited; use "||" instead Actual result: -------------- FOUND 0 ERROR(S) AND 0 WARNING(S) AFFECTING 0 LINE(S) IN TOTAL

Comments

 [2009-11-18 06:23 UTC] squiz (Greg Sherwood)
-Status: Open +Status: Closed -Assigned To: +Assigned To: squiz
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.